Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong main field in package.json #43

Closed
lehni opened this issue Jul 5, 2017 · 2 comments
Closed

Wrong main field in package.json #43

lehni opened this issue Jul 5, 2017 · 2 comments

Comments

@lehni
Copy link
Contributor

lehni commented Jul 5, 2017

I've been trying to use codeflask from webpack, and I am getting the following error:

Module not found: Error: Can't resolve 'codeflask'

I discovered this is because inside package.json, the main field points to the non-existing index.js:

"main": "index.js",

I've manually changed it to this, and the import works:

"main": "src/codeflask.js",

It's almost too simple a fix for a PR, but I could create one if desired.

@piranna
Copy link

piranna commented Jul 5, 2017

It's almost too simple a fix for a PR, but I could create one if desired.

No pull-request is simple enough to don't do it, some are just typos on the readme and this is fairly more important, so go for it ;-)

@lehni
Copy link
Contributor Author

lehni commented Jul 5, 2017

Oh wait, this isn't actually enough to fix it. It also needs AMD / CommonJS & co. logic for this to work correctly. I will create a proper PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants