Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module analysisTools imports local module dataTools incorrectly #30

Closed
themowski opened this issue Nov 19, 2019 · 1 comment
Closed

Comments

@themowski
Copy link

themowski commented Nov 19, 2019

We're having issues importing the pysheaf.analysisTools module because the module imports pysheaf.dataTools by simply saying import dataTools:

import dataTools

That works within the module since the file is local, but external programs that try to import pysheaf.analysisTools can't resolve this import of dataTools, since they don't know where the module lives.

The fix should be just replacing import dataTools with from . import dataTools in analysisTools.py.

We tested this fix locally and that resolved the issue -- import pysheaf.analysisTools worked as expected in our external program.

@kb1dds
Copy link
Owner

kb1dds commented Nov 20, 2019

Latest commit to master should fix this!

@kb1dds kb1dds closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants