Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the BGP-4 packet header's marker #64

Closed
kbandla opened this issue Jun 4, 2015 · 1 comment
Closed

fix the BGP-4 packet header's marker #64

kbandla opened this issue Jun 4, 2015 · 1 comment

Comments

@kbandla
Copy link
Owner

kbandla commented Jun 4, 2015

From lengletr...@googlemail.com on August 04, 2010 22:44:53

The BGP-4 spec says that the marker must be "all ones", which means all bits set to one, not bytes equal to 0x01 as is currently done in Dpkt. This bug prevents generating BGP-4 packets correctly without specifying the correct marker field manually.

Specifically, please modify class dpkt.bgp.BGP to change:
('marker', '16s', '\x01' * 16),
into:
('marker', '16s', '\xff' * 16),

Original issue: http://code.google.com/p/dpkt/issues/detail?id=37

@kbandla
Copy link
Owner Author

kbandla commented Jun 4, 2015

From dugsong on January 06, 2011 07:52:01

Thanks - fixed in r76

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant