Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

JavaScript to Thrift Service tests #117

Merged
merged 36 commits into from
Nov 21, 2015
Merged

JavaScript to Thrift Service tests #117

merged 36 commits into from
Nov 21, 2015

Conversation

dangunter
Copy link
Contributor

Using various JS tools to run some tests on the services.

@codecov-io
Copy link

Current coverage is 66.02%

Merging #117 into develop will not affect coverage as of 32935eb

@@            develop    #117   diff @@
=======================================
  Files            11      11       
  Stmts          2222    2222       
  Branches          0       0       
  Methods           0       0       
=======================================
  Hit            1467    1467       
  Partial           0       0       
  Missed          755     755       

Review entire Coverage Diff as of 32935eb

Powered by Codecov. Updated on successful CI builds.

@dangunter dangunter changed the title [WIP] JavaScript to Thrift Service tests JavaScript to Thrift Service tests Nov 20, 2015
@dangunter
Copy link
Contributor Author

This PR is ready to merge. It has the framework defined and 2 working tests. The plan is to:

  • merge this into develop
  • delete the branch on my fork
  • re-create the branch off the new develop
  • add a buttload of JavaScript tests using the framework
  • start a new PR to merge all the new tests in

This way, this branch/PR doesn't sit off in the fork for too long. It's already been a while, and I need to pick up all the new service code from develop.

@mlhenderson can you take a look and if it looks OK merge the PR?

@dangunter
Copy link
Contributor Author

@mlhenderson coverage is back to 2/3 of evil .. approve??

@mlhenderson
Copy link
Contributor

I respect your commitment to coverage of evil.

mlhenderson added a commit that referenced this pull request Nov 21, 2015
JavaScript to Thrift Service tests
@mlhenderson mlhenderson merged commit 40bdf7d into kbaseattic:develop Nov 21, 2015
@dangunter dangunter deleted the service_tests branch April 7, 2016 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants