-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Can we get some tests running in TravisCI? |
At the moment all the tests rely on having a kbase auth token. There are On Tue, Jul 28, 2015 at 12:42 PM, Dan Gunter notifications@github.com
|
OK. I would say getting some tests should be high priority. We should do mocks or local MongoDB (TravisCI has one) to get it running. But we need to get going, so I'll look at code now. |
So, the code looks close enough. I don't know if any of it works, but since Matt claims it does I'll take his word for it. The style of comments is not exactly correct (see Google Python Style, which is what this is imitating, I believe) and this may make generating docs a pain even with the napoleon Sphinx plugin. |
You can actually verify that at least basic tests work without too much On Tue, Jul 28, 2015 at 1:35 PM, Dan Gunter notifications@github.com
|
Yes, it is pseudo Google docstring style. We can change that, I don't have On Tue, Jul 28, 2015 at 1:35 PM, Dan Gunter notifications@github.com
|
I think you need better module level documentation In [3]: assembly? it would be really helpful if each module provided an overview of the functions |
looks good -- doc and test changes can be made later in separate PR
Some prototype code for an API library that works on genome annotations, assemblies, taxons.
This code works against two different type varieties, the current Genome object types and a new set that we want to validate, both of which will be abstracted behind these API methods so that developers can code against the API and not need to have deep knowledge of how the type information is structured or embed that knowledge in various pieces of our codebase.
There is a top level README.md that has instructions for getting the code installed. Since this is a prototype, many things are subject to change in the design.