Fix remove orphans #25
Conversation
The condition to remove it was index > len and should be index >= len Also used standard library function Vec::retain
|
Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @kbknapp (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
thanks for this fix! 👍 @homu r+ |
|
📌 Commit 1d1f60a has been approved by |
Fix remove orphans I investigated #24 and I found 2 problems: * When an orphan node was detected and removed, the indexes in the nodes vector changed for all the nodes after it, but the edges were not updated to match new indexes. It then triggered an out-of-bound panic on the next loop execution. Also, edges originating from the removed node were not removed. * The preliminary bound check was incorrect and did not remove edges pointing at/originating from 1-past the number of nodes, resulting in an out-of-bound panic in the next loop.
|
⚡ Test exempted - status |
|
Could you publish a new version with that change, because I have the same problem with installing from cargo-extras ? |
|
Ah yeah, sorry! |
|
@amarant v0.2.2 is out on crates.io |
I investigated #24 and I found 2 problems: