Issue 262 - Result and Lossy options for invalid Unicode #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @james-darkfox (rust_highfive has picked a reviewer for you, use r? to override) |
kbknapp
changed the title
|
@homu r+ |
|
📌 Commit 87ba544 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 22, 2015
Issue 262 - Result and Lossy options for invalid Unicode This allows not `panic!`ing on invalid unicode characters, and the option of returning lossy results. This does **not** turn all results into an `OsStr` preserving invalid unicode. If this helps with #262 we can merge (after review), otherwise we'll continue to discuss if there's a better way to handle this issue.
|
☀️ Test successful - status |
|
☔ The latest upstream changes (presumably #265) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows not
panic!ing on invalid unicode characters, and the option of returning lossy results. This does not turn all results into anOsStrpreserving invalid unicode.If this helps with #262 we can merge (after review), otherwise we'll continue to discuss if there's a better way to handle this issue.