This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Permit an absent content-type #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @kbknapp (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
aidanhs
force-pushed
the
aphs-no-content-type
branch
from
9da3127
to
8a707ae
Compare
|
@homu r+ |
|
📌 Commit 8a707ae has been approved by |
homu
added a commit
that referenced
this pull request
May 6, 2016
Permit an absent content-type Despite what the DO docs say for deleting a droplet (https://developers.digitalocean.com/documentation/v2/#delete-a-droplet), it does not appear to return with any content type (which is valid). I think the better way to handle this would be to make content-type an Option and bump the version of doapi-rs due to the backwards incompatibility - let me know if you're ok with this and I'll alter this PR.
|
⚡ Test exempted - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what the DO docs say for deleting a droplet (https://developers.digitalocean.com/documentation/v2/#delete-a-droplet), it does not appear to return with any content type (which is valid).
I think the better way to handle this would be to make content-type an Option and bump the version of doapi-rs due to the backwards incompatibility - let me know if you're ok with this and I'll alter this PR.