Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Android code, referenced in readme #1

Open
gmale opened this issue Feb 16, 2019 · 0 comments
Open

Bug in Android code, referenced in readme #1

gmale opened this issue Feb 16, 2019 · 0 comments

Comments

@gmale
Copy link

gmale commented Feb 16, 2019

Your project was the first helpful example I found of what I'm trying to accomplish so I figured I'd circle back and try to return the favor of being helpful.

In the android readme, you mention:

Actually, my codes have something wrong, so this listener never called 😇

This is because you did not add your imageReader surface to the previewRequestBuilder. It's good that you include it in the capture session but it needs to ALSO be in the preview request:

previewRequestBuilder.addTarget(surface)

I'm still figuring all this out and I don't have it completely working yet but this S.O. answer is helping me sort through how to get image data from the preview and feed it over to a firebase detector. I hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant