New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement request: FritzStatus and FritzConnection #134
Comments
Forgot to mention Simone |
To provide a method for For the other ones: why just not call For i.e. if you have a fritzconnection instance
|
Of course we can easily go with an implementation like you suggested, but HomeAssistant pushes for all low level calls to happen on the library side. As we agree on Thx in advance, Simone |
Regarding low level: everything that happen behind
I can follow the basic idea behind this, but it is a restriction that can easily get circumvented: just write an adapter class as library substitute.
May be, but no timeline, because next busy season is on the horizon. |
What if I do the coding ? ;-) Simone |
In this case you have to go through the review ;-) My first idea was to reuse the processor from core.processor, but according to the AVM documentation page 8 ff. this will not work, because some tag names have dashes. So the next idea is to convert the tags more to pep8 and provide them as attributes on item objects. Or keep the tags for use as keys in a dict, to keep in better sync with the AVM doc. Or both :) |
Well, I see that it would just take a minor code change in the processor to convert the dashes to underlines, so that the tag-names are useable as attributes (with this minor name change). That would make it very easy to convert the xml-content to a list of item-objects. |
@chemelli74: I was curious and implemented a prototype of |
Thx for the quick feedback! Really appreciated! Today, as I'm back home, I was able to do a first test.
Those are the same for all my devices, and on 99% of the cases are wrong. Finally there are 2 values contrasting:
Disallow should be Any idea it there is some issue with conversion or is the API broken ? Simone |
Thank you for testing – I was wondering about this too. As I can see now, it is a bug in the converter dictionary: |
Did a very quick test, values seem fine now. Simone |
After more testing, all seems working as expected. Can you please consider merging and releasing 1.9.2 ? :-) |
As it is a new feature, I suppose this is a candidate for 1.10 and not a hot-fix like 1.9.1 :) |
Do you have a timeframe in mind for the new major release ? If so, can you share it with us ? Simone |
There is no timeframe like "one update every two weeks" or so. I try to cover hot-fixes (like 1.9.1) at patch-level as soon as possible. Minor releases are typically done when new features have been implemented, tested and documented. In general this project tries to follow semantic versioning for releases. That is also not covered by the documentation so far. |
Klaus, would be super cool to get this merged as well ;-) Thank you for considering. Simone |
It's committed but with a different implementation and a different name ( |
Thx, didn't noticed! So I guess we can go as far as closing this issue. Simone |
Well – the commit was just a few hours ago. |
Hi @kbr,
I would like to add some calls to fritzconnection.
In details:
FritzConnection:
FritzStatus:
The idea is to get all info limiting the number of call towards the device.
We would also need such approach to get a better implementation on HomeAssistant side so we can easily get a DataUpdateCoordinator to fetch and cache the needed info.
Will you accept related PRs ?
Thx,
Simone
cc @mib1185
The text was updated successfully, but these errors were encountered: