-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions to rework string that informs about uploading of each item #9
Comments
Surrounding names with quotes is a fair point, will add.
What do you mean by "if name at remote can't be defined"? Hmmm, can't really see much benefit to adding 'done' to the end to be honest - the fact it moved on to something else means it was successful. The task will fail if the upload failed, for whatever reason. |
Ah, OK. I got it. Maybe replace "Uploading" with "Start uploading"? Just to be more clear |
Lets assume that its possible to upload file with name
But I guess changing name is not possible. so after upload file will have same name. So I suggest to change output string to next
in case if destination is root you need to write
or
Btw do you support an empty "dest" param ie "root folder" |
changing the name of a file to be uploaded could be possible by allowing a transform function to be passed in as an option, but not sure quite how useful that would be. I guess I can see some use for it though. My opinion is that it's clearer to log the full path of the uploaded file, even though the local and remote file names will always be the same at the moment. Uploading to the root of your Dropbox folder should be possible by specifying the destination as "", but I'm yet to test that that behaviour works. |
Not sure how useful a transform function is. Closing this at the moment but if there's any more requests for this change can look at it again. |
I have next string:
Have next ideas:
The text was updated successfully, but these errors were encountered: