Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to rework string that informs about uploading of each item #9

Closed
ZuBB opened this issue Sep 12, 2014 · 5 comments
Closed

Comments

@ZuBB
Copy link

ZuBB commented Sep 12, 2014

I have next string:

Uploading GBO Injector Tester-v0.9.3.exe to Public/GBO Injector Tester binaries/GBO Injector Tester-v0.9.3.exe...

Have next ideas:

  • my 'item' has spaces in it. would be nice to surround it with any type of quotes to increase readability?
  • same as above but for destination path?
  • if name at remote cant be defined, maybe its better to remove item name from destination path?
  • How about to add 'done' word at the end of each that line if upload of nth item completed successful? if its complicated, ignore this
@kbremner
Copy link
Owner

Surrounding names with quotes is a fair point, will add.

if name at remote cant be defined, maybe its better to remove item name from destination path

What do you mean by "if name at remote can't be defined"?

Hmmm, can't really see much benefit to adding 'done' to the end to be honest - the fact it moved on to something else means it was successful. The task will fail if the upload failed, for whatever reason.

@ZuBB
Copy link
Author

ZuBB commented Sep 12, 2014

Hmmm, can't really see much benefit to adding 'done' to the end to be honest - the fact it moved on to something else means it was successful. The task will fail if the upload failed, for whatever reason.

Ah, OK. I got it. Maybe replace "Uploading" with "Start uploading"? Just to be more clear

@ZuBB
Copy link
Author

ZuBB commented Sep 12, 2014

Lets assume that its possible to upload file with name file1.jpg to Public/file2.jpg ie changing name at same time. in this case its OK to print smth like this

Uploading file1.jpg to Public/file2.jpg...

But I guess changing name is not possible. so after upload file will have same name. So I suggest to change output string to next

Uploading file1.jpg to Public/...

in case if destination is root you need to write

Uploading file1.jpg to /...

or

Uploading file1.jpg to /(root folder)...


Btw do you support an empty "dest" param ie "root folder"

@kbremner
Copy link
Owner

changing the name of a file to be uploaded could be possible by allowing a transform function to be passed in as an option, but not sure quite how useful that would be. I guess I can see some use for it though.

My opinion is that it's clearer to log the full path of the uploaded file, even though the local and remote file names will always be the same at the moment.

Uploading to the root of your Dropbox folder should be possible by specifying the destination as "", but I'm yet to test that that behaviour works.

@kbremner
Copy link
Owner

Not sure how useful a transform function is. Closing this at the moment but if there's any more requests for this change can look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants