Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mind if we use your code in the Python extension for VS Code? #57

Closed
brettcannon opened this issue Dec 10, 2019 · 3 comments
Closed

Mind if we use your code in the Python extension for VS Code? #57

brettcannon opened this issue Dec 10, 2019 · 3 comments

Comments

@brettcannon
Copy link

We are starting to look into fixing our indentation situation for https://github.com/microsoft/vscode-python and we realized your extension covers a lot of the cases we want to handle well. Do you have any qualms if we used your code to implement a solution? (I know your MIT license would allow use to copy without asking but it felt nicer to ask first. 😃 )

@kbrose
Copy link
Owner

kbrose commented Dec 14, 2019

@brettcannon No issues at all, I'd be honored. Be sure to also check out https://github.com/DSpeckhals/python-indent-parser written by @DSpeckhals with contributions from me as well.

@DSpeckhals do you have any qualms with the use of that library either?

@DSpeckhals
Copy link
Contributor

DSpeckhals commented Dec 14, 2019

@kbrose No qualms here! It will be better to have this in core vs. an extension anyway. 😄

@brettcannon
Copy link
Author

@kbrose yep, we're aware of python-indent-parser as well.

@DSpeckhals @kbrose thanks to both of you for your support!

In case you're curious, our spike to research the topic has been tracked in microsoft/vscode-python#8996. We don't have an ETA of when we will get to this (quarterly priorities are being worked out still), but this is definitely something we want to see solved.

Also know that we do appreciate you both putting the work that you have put in to help make up for us not getting to this issue yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants