Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material UI theme provokes FTA-FMEA to crash #305

Open
LaChope opened this issue May 18, 2024 · 7 comments · May be fixed by #343
Open

Material UI theme provokes FTA-FMEA to crash #305

LaChope opened this issue May 18, 2024 · 7 comments · May be fixed by #343
Assignees
@LaChope

Comments

@LaChope
Copy link
Collaborator

LaChope commented May 18, 2024 •
edited
Loading

NOTE: #343 might solve this issue, but #365 must be completed first to be able to test the fix.

@blcham @Kasmadei
On both the development server and dockerized version, app crashes with:

Firefox error:
Image

Chrome error:
Image

The issue comes very probably from the changes of this commit.
@LaChope LaChope assigned LaChope and unassigned LaChope May 18, 2024
@kbss-cvut kbss-cvut deleted a comment from Kasmadei May 18, 2024
@LaChope LaChope mentioned this issue May 18, 2024
Merged
@LaChope
Copy link
Collaborator Author

LaChope commented May 19, 2024 •
edited
Loading

#309 fixes part of it. When using internal auth, it works when loading the app for the first time, but if you refresh (also CTRL + F5), app crashed with the same error as above. This behavior occurs even after 155a79d and 09517db, we just did not try to refresh page before.

I tried to remove all useTheme hooks from all files, but the issue still occurs.

@LaChope
Copy link
Collaborator Author

LaChope commented May 19, 2024

Reopening as not completed (see comment just above)

@LaChope LaChope reopened this May 19, 2024
@blcham
Copy link
Contributor

blcham commented May 24, 2024

It might be little relevant to: kbss-cvut/record-manager-ui#125 (comment)

LaChope added a commit that referenced this issue Jun 3, 2024
@LaChope
[Fix #305] Fixed app crashing when using internal auth
06b65e1
LaChope added a commit that referenced this issue Jun 3, 2024
@LaChope
[Fix #305] Fixed missing import statement
55bd39b
@LaChope LaChope linked a pull request Jun 5, 2024 that will close this issue
Fixed app crashing when using internal auth #343
Open
@blcham
Copy link
Contributor

blcham commented Jun 10, 2024

@LaChope what do you propose to do with this? Should we put it to TODO ?

@LaChope
Copy link
Collaborator Author

LaChope commented Jun 10, 2024

Yes, also I am updating the description as #365 should be completed before this.

@blcham
Copy link
Contributor

blcham commented Jul 10, 2024 •
edited
Loading

@LaChope I guess this is not relevant for the delivery -- putting it into "technical debt sprint"

@LaChope
Copy link
Collaborator Author

LaChope commented Jul 10, 2024

@blcham yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaChope LaChope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed app crashing when using internal auth kbss-cvut/fta-fmea-ui
2 participants
@blcham @LaChope