Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mafia 1 - strange reverb feedback loop in some locations #94

Open
Lrflx opened this issue Sep 8, 2023 · 6 comments
Open

Mafia 1 - strange reverb feedback loop in some locations #94

Lrflx opened this issue Sep 8, 2023 · 6 comments

Comments

@Lrflx
Copy link

Lrflx commented Sep 8, 2023

During my last playthrough I noticed that in several locations something strange definitely was happening. Easiest to check is in prison tower, with alchemy there's a slight humming trail going on for couple seconds after every gunshot. And with dsoal it just keeps going on and on instead, practically indifinetiley and doesn't stop even in main menu. Tested it with reverb boost setting and it does change reverb in general, but doesn't have any audible effect on that feedback loop humming.
Mafia.zip

@mirh
Copy link

mirh commented Sep 8, 2023

With the last git?

@Lrflx
Copy link
Author

Lrflx commented Sep 8, 2023

Yes, just did it and same thing is happening there

@kcat
Copy link
Owner

kcat commented Sep 8, 2023

FWIW, there is newer code in the C++ rewrite branch (although I don't expect EAX/reverb behavior to be much different; and that branch is currently missing a few features like capture/duplex operation and WRITEPRIMARY support, that still need to be reimplemented).

I do need to find some way to log the EAX parameters being set, in a way that doesn't significantly impact performance when not logging. The reverb gain shouldn't be significantly different, nor should the decay tail, so it'd be helpful to see what EAX property values are being set.

@Lrflx
Copy link
Author

Lrflx commented Sep 8, 2023

Ok, I'll be glad to retest it whenever it comes out. To be honest I'm not sure if it's even a reverb, sounds more like reflections, don't know for sure if EAX 3 can to it.

@kcat
Copy link
Owner

kcat commented Sep 8, 2023

Are you able to provide a recording of it happening? Preferably of both ALchemy and DSOAL for comparison.

@Lrflx
Copy link
Author

Lrflx commented Sep 8, 2023

Of course. Some additional clipping got there during capture, it wasn't in game originally
Mafia.Alchemy.DSOAL.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants