Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to allow pods to talk to pcluster apiservers? #206

Closed
ncdc opened this issue Nov 12, 2021 · 3 comments
Closed

Do we want to allow pods to talk to pcluster apiservers? #206

ncdc opened this issue Nov 12, 2021 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. severity/experience-blocker Something that considerably blocks the user experience of kcp

Comments

@ncdc
Copy link
Member

ncdc commented Nov 12, 2021

Is your feature request related to a problem? Please describe.
Pre-kcp, when I write a controller and deploy it as a pod (via a deployment) to my cluster, it typically talks to kubernetes.default.svc using in-cluster config to communicate with the apiserver (e.g. to manipulate CRs).

Post-kcp, when I apply a deployment to kcp, the resulting pod(s) run in a physical cluster, but we want them talking to the kcp apiserver to perform operations against CRs and whatnot. If we don't do anything, when the pod resolves kubernetes.default.svc, it is for the physical cluster. The pod won't be able to see the CRs in the kcp apiserver because of this.

The above is covered by #280

Rescoping this to ask: do we want to allow pods to talk to pcluster apiservers? If so, how?

Describe the solution you'd like
Assuming we want to, figure out how to handle pods talking to pcluster apiservers:

  1. Pod wants to manipulate CRs
    1. Needs DNS for kubernetes service to resolve to KCP?
    2. Needs env vars for kubernetes to resolve to KCP?
    3. Needs SA token from kcp namespace injected into pod in physical cluster
  2. Pod wants to talk to physical cluster apiserver
    1. Is this a valid use case?
    2. If so, what permissions (SA token) does it use?
    3. Does it use DNS? env vars?
@ncdc ncdc added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 12, 2021
@ncdc ncdc added the severity/experience-blocker Something that considerably blocks the user experience of kcp label Feb 23, 2022
@ncdc ncdc added this to the Prototype 3 milestone Feb 23, 2022
@ncdc ncdc changed the title Figure out pod -> apiserver semantics in a logical/physical cluster world Do we want to allow pods to talk to pcluster apiservers? Mar 3, 2022
@ncdc
Copy link
Member Author

ncdc commented Mar 3, 2022

Rescoping to just case 2 - "pod wants to talk to physical cluster apiserver" as case 1 is handled by #280

@ncdc ncdc modified the milestones: Prototype 3, TBD Mar 3, 2022
@sttts
Copy link
Member

sttts commented May 5, 2022

I don't see how this is a valid use-case. Why would one want to talk to a pcluster, and why isn't that something outside of the standard TMC flow?

@ncdc
Copy link
Member Author

ncdc commented May 24, 2022

Agreed, closing

@ncdc ncdc closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. severity/experience-blocker Something that considerably blocks the user experience of kcp
Projects
Status: New
Development

No branches or pull requests

2 participants