Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in src/algorithms/donut.py(P2) #209

Open
DLPerf opened this issue Aug 23, 2021 · 1 comment
Open

Performance issues in src/algorithms/donut.py(P2) #209

DLPerf opened this issue Aug 23, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 23, 2021

Hello,I found a performance issue in the definition of fit ,
src/algorithms/donut.py,
tf_session = tf.Session was repeatedly called in for col_idx in trange(len(X.columns)): and was not closed.
I think it will increase the efficiency and avoid out of memory if you close this session after using it.

Here are two files to support this issue,support1 and support2

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@Chaoste
Copy link
Contributor

Chaoste commented Aug 23, 2021

Hey,
that sounds reasonable. It would be great if you file a PR. I will review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants