Fix click-log API change. Issue #58 #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix breaking API change introduced with Click-Log 0.2.0. Running the script with Python 3.5 required to capture a UnicodeEncodeError exception instead of UnicodeDecodeError.
|
I'm going to decline this PR as duplicates of #60. As for UnicodeError, can you create another PR with the appropriate unittest please? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
kdeldycke
added
🐛 bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking API change introduced with Click-Log 0.2.0 reported in #58.
Running the script with Python 3.5 required to capture a UnicodeEncodeError exception instead of UnicodeDecodeError.