Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore state class of the Sensor and create HistoricalSensor #43

Closed
kdeyev opened this issue Aug 22, 2023 · 3 comments
Closed

Restore state class of the Sensor and create HistoricalSensor #43

kdeyev opened this issue Aug 22, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kdeyev
Copy link
Owner

kdeyev commented Aug 22, 2023

As per discussion here #30:

  • HistoricalSensor should have an undefined state_class and should keep all the logic related to historical data imports
  • Sensor should have proper state_class and should keep all the logic but historical data imports (as it was before v2.0)
@kdeyev kdeyev added the enhancement New feature or request label Aug 22, 2023
@disforw
Copy link
Collaborator

disforw commented Aug 22, 2023

I’ll take this…
I’ll open a new branch, can I pull form master?

@kdeyev
Copy link
Owner Author

kdeyev commented Aug 22, 2023

Yes, everything is merged into the master.
Thank you!

@kdeyev
Copy link
Owner Author

kdeyev commented Aug 25, 2023

@disforw It sounds like all the workarounds did not work and we need to implement this solution.

This was referenced Aug 28, 2023
Closed
Merged
@kdeyev kdeyev closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdeyev @disforw