Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification around some test cases with dashes and dots #169

Closed
benjreinhart opened this issue Sep 16, 2021 · 1 comment
Closed

Clarification around some test cases with dashes and dots #169

benjreinhart opened this issue Sep 16, 2021 · 1 comment

Comments

@benjreinhart
Copy link
Contributor

Hello there! I'm looking for some clarification on what I believe to be a discrepancy between the tests and spec.

I was looking at the following test cases:

Both of these are in the input folder but not the expected_kdl folder, implying they are invalid / raise errors. However, both seem to be valid identifiers according to the spec.

node --
node .0

If I'm reading the spec right, dashes and dots seem to be valid anywhere in an identifier, including the initial character. If that's true, are these tests outdated / incorrect, or am I missing something?

@benjreinhart
Copy link
Contributor Author

Ohh, my bad, that's invalid not because of the identifier, but because identifiers cannot be arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant