Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly Missing Step in Instructions? #1

Closed
Sewdohe opened this issue May 11, 2022 · 1 comment
Closed

Possibly Missing Step in Instructions? #1

Sewdohe opened this issue May 11, 2022 · 1 comment

Comments

@Sewdohe
Copy link

Sewdohe commented May 11, 2022

I followed the instructions in the readme, but the last step I don't have an app.mk file as in the example commit. If I add

# Repainter integration
PRODUCT_PACKAGES += \
    RepainterServicePriv \

anywhere else I see the variable occur, I get the following error:

[ 99% 227/228] finishing build rules ...
FAILED:
build/make/core/artifact_path_requirements.mk:26: warning:  build/make/target/product/generic_system.mk produces files outside its artifact path requirement. Allowed paths are root/*, system/*
Offending entries:
system_ext/etc/permissions/privapp_whitelist_dev.kdrag0n.dyntheme.privileged.sys.xml
system_ext/priv-app/RepainterServicePriv/RepainterServicePriv.apk
system_ext/priv-app/RepainterServicePriv/oat/arm64/RepainterServicePriv.odex
system_ext/priv-app/RepainterServicePriv/oat/arm64/RepainterServicePriv.vdex
In file included from build/make/core/main.mk:1346:
build/make/core/artifact_path_requirements.mk:26: error: Build failed.
22:31:42 ckati failed with: exit status 1

Am I simply dense to something obvious, or is there a step missing in the instructions? After some googling I found this link that seems relevant, but not sure how it ties in.

I do dearly apologize if this doesn't constitute as an actual issue .

@kdrag0n
Copy link
Owner

kdrag0n commented May 19, 2022

Either disable artifact path requirements as a workaround or add it to a makefile that's meant for /system_ext. Different product makefiles are supposed to include build rules for different partitions; the one you added it to, generic_system.mk, is only for /system.

@kdrag0n kdrag0n closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants