Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select Touching", then "Delete" deletes all brushes in func_detail #1409

Closed
ericwa opened this issue Aug 8, 2016 · 5 comments
Closed

"Select Touching", then "Delete" deletes all brushes in func_detail #1409

ericwa opened this issue Aug 8, 2016 · 5 comments
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems

Comments

@ericwa
Copy link
Collaborator

ericwa commented Aug 8, 2016

..including brushes that were not selected by the "Select Touching" command.

To reproduce:

  1. Create two brushes "A" and "B" and combine them into a func_detail entity
  2. Create another brush that touches brush "A" only, and use the "Select Touching" command. Brush "A" becomes selected.
  3. Press Delete.

Expected: only brush "A" is deleted.
Observed: both brush "A" and "B" are deleted.

TrenchBroom 2.0.0 Alpha Build 63a040d RelWithDebInfo

@kduske kduske added this to the TrenchBroom 2.0.0 milestone Aug 8, 2016
@kduske kduske added Type:Bug Errors and problems Platform:All Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Aug 8, 2016
@ericwa
Copy link
Collaborator Author

ericwa commented Aug 13, 2016

Probably related / same underlying problem:

  • open a complete map
  • drag a large selection brush touching several brushes + entities, and do "select touching"
  • drag to move the selected brushes
  • undo
  • undo

The last undo will corrupt the map - large chunks are getting moved around.

@kduske
Copy link
Collaborator

kduske commented Sep 8, 2016

Fixed in bf0dcc4.

@kduske kduske closed this as completed Sep 8, 2016
@kduske
Copy link
Collaborator

kduske commented Sep 8, 2016

I couldn't reproduce the second bug - could you please try it, too?

kduske added a commit that referenced this issue Sep 8, 2016
@ericwa
Copy link
Collaborator Author

ericwa commented Sep 8, 2016

Thanks! I confirmed the second bug is also fixed by bf0dcc4

@kduske
Copy link
Collaborator

kduske commented Sep 8, 2016

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems
Projects
None yet
Development

No branches or pull requests

2 participants