Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antialiasing disabled #1560

Closed
ericwa opened this issue Dec 21, 2016 · 13 comments
Closed

Antialiasing disabled #1560

ericwa opened this issue Dec 21, 2016 · 13 comments
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Bug Errors and problems

Comments

@ericwa
Copy link
Collaborator

ericwa commented Dec 21, 2016

Seems like antialiasing got disabled at some point in the last month or so..

Screenshot I took last week on d190c59 / macOS:
screenshot

muk0r reports it on the f7fe54e Windows build from appveyor:
http://celephais.net/board/view_thread.php?id=60908&start=2425&end=2425

I'm not sure when AA was last working

@muk0r
Copy link

muk0r commented Dec 21, 2016

The "previous build" I mention is "2db2dad", by the way. Sorry for the lack of clarity

@kduske kduske added this to the TrenchBroom 2.0.0 milestone Dec 21, 2016
@kduske kduske added Type:Bug Errors and problems Platform:All Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Dec 21, 2016
ericwa added a commit to ericwa/TrenchBroom that referenced this issue Dec 22, 2016
Broken in 5137411 when a `!m_initialized` condition on the for loop was removed
kduske added a commit that referenced this issue Dec 23, 2016
@kduske kduske closed this as completed Dec 23, 2016
@kduske
Copy link
Collaborator

kduske commented Dec 23, 2016

Fixed in 7ce181f.

@JackViney96
Copy link

Still present in RC3 -
screenshot from 2017-02-04 13-51-03

Fedora 25, any other specs I need to provide?

@ericwa
Copy link
Collaborator Author

ericwa commented Feb 4, 2017

I can reproduce, with the RC3 .rpm installed on a Fedora 25 VM in VirtualBox, with software OpenGL... but that may just not support multisampling.

What's in the console after launching TB and creating a new map?
I get:
"Renderer info: Gallium 0.4 on llvmpipe ...
Depth buffer bits: 32
Multisampling disabled"

@ericwa
Copy link
Collaborator Author

ericwa commented Feb 4, 2017

Yeah, sounds like the llvmpipe software renderer just doesn't have multisampling: https://lists.freedesktop.org/archives/mesa-dev/2015-June/086674.html
So in my case TB is behaving as expected.

@JackViney96
Copy link

Here's what I've got in my console, for posterity.

[jviney@jack-laptop-localdomain ~]$ trenchbroom

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(trenchbroom:4591): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(trenchbroom:4591): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width 0 and height -2

(trenchbroom:4591): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -2 and height 0
  

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

No, TB's console.

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

On my Xubuntu Parallels VM, I get reported that multisampling is enabled, but it the display looks jagged. I have to admit that I don't really care about this. If wxWidgets reports that it works, but then it doesn't, it's either a driver problem or a wxWidgets problem.

bildschirmfoto 2017-02-04 um 07 42 38

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

Console reports

Renderer info: Parallels using AMD Radeon R9 M395X OpenGL Engine version 2.1 ATI-1.48.16 from Parallels and ATI Technologies Inc.
Depth buffer bits: 24
Multisampling enabled
Creating new document
Loaded entity definition file Quake.fgd

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

Addendum: I think that it worked in Parallels VMs at some point. Also, I made sure that our glx11 patch was applied to wxWidgets in my VM. I'm going to try the official TB2 RC3 deb also.

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

Same with the deb package on a fresh install.

@kduske kduske added Prio:3 Low priority: Minor problems and nice to have features and removed Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Feb 4, 2017
@kduske kduske removed this from the TrenchBroom 2.0.0 milestone Feb 4, 2017
@kduske kduske changed the title Antialiasing disabled Antialiasing disabled on Linux Feb 4, 2017
@kduske kduske changed the title Antialiasing disabled on Linux Antialiasing disabled Feb 4, 2017
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Feb 4, 2017
@ericwa
Copy link
Collaborator Author

ericwa commented Feb 4, 2017

Just tried the RC3 deb on real hardware with Ubuntu 16.04, nvidia 9400m, open source (nouveau) drivers.. it works here; prints "Multisampling enabled" in the TB console and it's indeed multisampled.

@kduske
Copy link
Collaborator

kduske commented Feb 4, 2017

Alright then. I don't think it's a problem with TB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Bug Errors and problems
Projects
None yet
Development

No branches or pull requests

4 participants