Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SimpleHaskellMarker to backend #30

Merged
merged 4 commits into from Jan 3, 2017
Merged

Move SimpleHaskellMarker to backend #30

merged 4 commits into from Jan 3, 2017

Conversation

helicopter88
Copy link
Collaborator

  • Ignore Bench and Test files
  • Switch to JSONParser instead of JSON simple

@helicopter88
Copy link
Collaborator Author

I have no idea what does the test failure mean, nor why it fails

@giuliojiang
Copy link
Collaborator 

[14:57:28][Step 1/1] -------------------------------------------------------
[14:57:28][Step 1/1]  T E S T S
[14:57:28][Step 1/1] -------------------------------------------------------
[14:57:29][Step 1/1] Running alabno.simple_haskell_marker.ArgumentsTest
[14:57:29][Step 1/1] Not enough arguments...
[14:57:29][Step 1/1] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.278 sec - in alabno.simple_haskell_marker.ArgumentsTest
[14:57:29][Step 1/1] Running alabno.simple_haskell_marker.CategoryConverterTest
[14:57:29][Step 1/1] CategoryConverter: could not find ErrorType for [rubbish]
[14:57:29][Step 1/1] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.218 sec - in alabno.simple_haskell_marker.CategoryConverterTest
[14:57:29][Step 1/1] Running alabno.simple_haskell_marker.HaskellBlockTest
[14:57:29][Step 1/1] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in alabno.simple_haskell_marker.HaskellBlockTest
[14:57:29][Step 1/1] Running alabno.simple_haskell_marker.HaskellSplitterTest
[14:57:30][Step 1/1] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 sec - in alabno.simple_haskell_marker.HaskellSplitterTest
[14:57:30][Step 1/1] Running alabno.simple_haskell_marker.HaskellMarkerTest
[14:57:30][Step 1/1] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec <<< FAILURE! - in alabno.simple_haskell_marker.HaskellMarkerTest
[14:57:30][Step 1/1] simpleCase(alabno.simple_haskell_marker.HaskellMarkerTest)  Time elapsed: 0.04 sec  <<< FAILURE!
[14:57:30][Step 1/1] java.lang.AssertionError: 
[14:57:30][Step 1/1]   Unexpected method call CategoryConverterInterface.getDescription(""):
[14:57:30][Step 1/1] 	at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:44)
[14:57:30][Step 1/1] 	at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:94)
[14:57:30][Step 1/1] 	at com.sun.proxy.$Proxy3.getDescription(Unknown Source)
[14:57:30][Step 1/1] 	at alabno.simple_haskell_marker.HaskellMarker.addAnnotations(HaskellMarker.java:86)
[14:57:30][Step 1/1] 	at alabno.simple_haskell_marker.HaskellMarker.generateOutput(HaskellMarker.java:68)
[14:57:30][Step 1/1] 	at alabno.simple_haskell_marker.HaskellMarker.mark(HaskellMarker.java:47)
[14:57:30][Step 1/1] 	at alabno.simple_haskell_marker.HaskellMarkerTest.simpleCase(HaskellMarkerTest.java:26)
[14:57:30][Step 1/1] 
[14:57:30][Step 1/1] 
[14:57:30][Step 1/1] Results :
[14:57:30][Step 1/1] 
[14:57:30][Step 1/1] Failed tests: 
[14:57:30][Step 1/1]   HaskellMarkerTest.simpleCase:26 
[14:57:30][Step 1/1]   Unexpected method call CategoryConverterInterface.getDescription(""):
[14:57:30][Step 1/1] 
[14:57:30][Step 1/1] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0

@helicopter88
Copy link
Collaborator Author

I have no idea why something that is meant to make the output of something should not call a method to get the description.

@helicopter88
Copy link
Collaborator Author

NVM fixed

@giuliojiang
Copy link
Collaborator

this is relying on maven caching for dependency resolution. Compilation is broken when maven cache is clear. I'll fix this

giuliojiang
giuliojiang reviewed Jan 1, 2017
View reviewed changes
backend/simple-haskell-marker/src/main/java/alabno/simple_haskell_marker/HaskellSplitter.java
@@ -154,7 +153,7 @@ private HaskellBlock tryGet(List<HaskellBlock> blocks, int index) {
}
}

public String getBlockTextAt(int lineNumber) {
String getBlockTextAt(int lineNumber) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making this non-public breaks compilation. Again, if maven cached the build, no error shows

Domenico Fabio Marino and others added 4 commits January 3, 2017 12:05
SimpleHaskellMarker: ignore Bench and Test files
0efcdbd 
Signed-off-by: Domenico Fabio Marino <dfm114@ic.ac.uk>
Move Simple Haskell Marker to backend
687cf04 
Signed-off-by: Domenico Fabio Marino <dfm114@ic.ac.uk>
Backend: SimpleHaskellMarker: Use JSONParser instead of simple json
8e5399d 
Signed-off-by: Domenico Fabio Marino <dfm114@ic.ac.uk>
@giuliojiang
fix dependency and compilation issues
dcdee51
@helicopter88 helicopter88 merged commit a91496c into master Jan 3, 2017
@giuliojiang giuliojiang deleted the shmfixes branch January 4, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliojiang giuliojiang giuliojiang approved these changes

@procaconsul procaconsul procaconsul approved these changes

@AbraaoMota AbraaoMota AbraaoMota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@helicopter88 @giuliojiang @procaconsul @AbraaoMota