Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why only for singletons #1

Open
amrdraz opened this issue Nov 20, 2017 · 3 comments
Open

why only for singletons #1

amrdraz opened this issue Nov 20, 2017 · 3 comments

Comments

@amrdraz
Copy link

amrdraz commented Nov 20, 2017

why can't we create thunks for dynamic components?

maybe this is not the correct use case but I want to create a logic component that loads different data depending on the props, key passed

is this wrong, should I explicitly assign the prop dynamic value as input to the action instead. and introduce methods purely built to call it in the component?

@mariusandra
Copy link
Member

Hey, there's a simple reason: I haven't had time to implement this :).

The best I can promise now is that I might have time to add support for it still this year. Could be next week, could be at the end of December... but I don't know as I have a busy period with travels coming up.

Feel free to take a crack at it if you'd like :).

@amrdraz
Copy link
Author

amrdraz commented Nov 20, 2017

I could go for it, I kinda understand the plugin system based on source code
but would you tell me your recommendation for implementing this feature?

is there documentation for plugin authoring I have had several ideas

what other kind of plugins are possible
what are the extension points

@mariusandra
Copy link
Member

There's no documentation for plugins yet. The API for plugins is still in flux and can change based on what's needed from future developments. I've been waiting to finish the redux-observable support to see how it would affect the plugin API... but haven't gotten to it yet.

The only "documentation" now is the globalPlugins hash in this file.

As for how to implement thunks for dynamic logic stores, I'm not sure. It shouldn't be a hard thing to do, but 5 min of thinking didn't reveal any elegant solution to the problem. It's even possible thunks will just work and maybe require a few small tweaks, but I don't know... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants