Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements individual property type override. This allows both general property naming and specific property type, mirroring the usage of
rename.properties
. I consider this an advanced feature, since this allows such fine control over single properties.Overriding Optional
Since this is an advanced feature and by definition allows one to override the actual property type, it could be thought that his encompasses the entire type which includes whether it is an
Optional
.For example, assume that
Pet.tag
would originally map toString?
, but with the below:this would result in
Pet.tag
mapping toUUID
, therefore making this required to the client. This can also happen the other way, making a non-optional property generate as an optional instead. This would also of course be a responsibility to the developer that the types can properly decode/encode.I don't do this here (
Optional
is stable through the type override), however I think this should be a consideration.