Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - adding the URLRequest to the delegate method shouldClientRetry #22

Closed
pkrusek opened this issue Mar 31, 2022 · 4 comments
Closed

Comments

@pkrusek
Copy link

pkrusek commented Mar 31, 2022

In the signature of the delegate method
func shouldClientRetry(_ client: APIClient, withError error: Error) async throws -> Bool
might be useful to add URLRequest.

This could be useful for handling situations where multiple requests fail.

Or can you please show an example or hint how you handle this situation?

@kean
Copy link
Owner

kean commented Mar 31, 2022

I agree, I think it's a good idea to add it. PRs are welcome.

@pkrusek
Copy link
Author

pkrusek commented Mar 31, 2022

OK, I'll set up a PR. Thanks.

@pkrusek
Copy link
Author

pkrusek commented Mar 31, 2022

PR created.

@kean
Copy link
Owner

kean commented Apr 3, 2022

Released in 0.6.0

@kean kean closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants