Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol for APIClient Methods #48

Closed
LePips opened this issue Aug 8, 2022 · 1 comment
Closed

Protocol for APIClient Methods #48

LePips opened this issue Aug 8, 2022 · 1 comment

Comments

@LePips
Copy link
Contributor

LePips commented Aug 8, 2022

I'm remaking our new API with CreateAPI and you've left generous comment in our thread jellyfin/jellyfin-sdk-swift#5. Instead of directly using APIClient, I'm making a wrapper JellyfinClient actor that handles the APIClientDelegate creation to inject required headers for the Jellyfin server, among other things for convenience.

Working with this wrapper would just manually require re-declaring the main APIClient interface methods however can cause issues in the future over the evolution of the package. Would creating a protocol for these methods be appropriate for easier implementation of wrappers?
@LePips
Copy link
Contributor Author

LePips commented Aug 8, 2022

Apologies, I don't know why I made an issue if I could just make the protocol and have the discussion there.

@LePips LePips closed this as completed Aug 8, 2022
@LePips LePips mentioned this issue Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LePips