New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailing ? when creating the request with empty query items #29

Merged

kean merged 1 commit into kean:main from binaryscraping:main

Apr 11, 2022

Contributor

grdsdev commented Apr 11, 2022

When creating a request with an empty query params, the request is created with a trailing ? without any parameter.

This PR adds a fix for setting the component's queryItems only when the query is non-empty.


          Set queryItems only when query is non-empty

acbe1f9

kean merged commit 23f1fb4 into kean:main

Owner

kean commented Apr 11, 2022

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment