Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke's UserDefaults value with key containing app path #717

Closed
Pash237 opened this issue Jul 28, 2023 · 3 comments
Closed

Nuke's UserDefaults value with key containing app path #717

Pash237 opened this issue Jul 28, 2023 · 3 comments

Comments

@Pash237
Copy link

Pash237 commented Jul 28, 2023

Nuke stores last sweep interval in UserDefaults and uses full path as a key.
But since iOS 8(?) app data path changes every re-install. This causes creating a new key for each install.

It's not that critical for production since re-installs didn't happen very ofter, but annoying while developing:
image

@kean
Copy link
Owner

kean commented Jul 28, 2023

Great catch, thanks! It didn't feel right, and now it's clear why.

In light of the policies on the use of these APIs, it makes even more sense to rework it. I'll push an update later today.

@kean
Copy link
Owner

kean commented Jul 28, 2023

I opened a PR with a fix #718 and would appreciate a quick review.
It's exactly how it's implemented in Pulse; not sure why I even went with UserDefaults. It was a bit easier to implement with UserDefaults.

@kean
Copy link
Owner

kean commented Jul 29, 2023

Fixed in version 12.1.5.
I appreciate the report, thanks!

@kean kean closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants