Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when filtering logs by Label or Function #116

Closed
AnthoPakPak opened this issue Sep 22, 2022 · 4 comments
Closed

Crash when filtering logs by Label or Function #116

AnthoPakPak opened this issue Sep 22, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@AnthoPakPak
Copy link

First, I want to thank you for this project, which can become really useful! I've integrated it and can't wait for it to save me some debugging time 馃槂

While trying it, I've noticed that both Pulse and Pulse Pro crash when trying to filter logs by either Label or Function. For example, on iOS, using Filter button > Changing "Message" to "Label" > Writing anything in the field > Crash. The same happens in Pulse Pro. And it also happens when filtering on Function.

Reported reason is unimplemented SQL generation for predicate : (label CONTAINS[c] "typedText"). I can provide the full crash log if needed.

You're probably already aware of this issue but I haven't seen this reported anywhere so I thought it might be a good idea to post an issue.

@kean kean added the bug Something isn't working label Sep 29, 2022
@kean
Copy link
Owner

kean commented Sep 29, 2022

Thanks for the report. Yes, the query seems is incorrect. It doesn't match the new structure introduced in Pulse 2.0.

@kean
Copy link
Owner

kean commented Sep 30, 2022

Apparently, function is a reserved word and can't be used as a key.

@kean
Copy link
Owner

kean commented Sep 30, 2022

Fixed in 2.1.3

@kean kean closed this as completed Sep 30, 2022
@AnthoPakPak
Copy link
Author

Just tried (both Pulse and Pulse Pro), all good! Thanks 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants