Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console row title is misleading with local file #161

Closed
ejensen opened this issue Feb 7, 2023 · 2 comments
Closed

Console row title is misleading with local file #161

ejensen opened this issue Feb 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ejensen
Copy link
Sponsor Contributor

ejensen commented Feb 7, 2023 •
edited

When loading a local file URL the URLResponse is a not an HTTPURLResponse so the statusCode = nil. The StatusCodeFormatter converts the 0 status code to the message 0 Sever Error even though the request succeeded.

local-file
@kean kean added the bug Something isn't working label Feb 7, 2023
@kean
Copy link
Owner

kean commented Feb 7, 2023

Thanks for the report. I think there might be more places where it's not handled correctly, even on the LoggerStore level. Needs more unit tests.

@kean kean closed this as completed in e42edf5 Feb 11, 2023
@kean
Copy link
Owner

kean commented Feb 11, 2023 •
edited

Fixed in version 3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejensen @kean