Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to present file browser when ParseUI is presented #19

Closed
johndelong opened this issue Jun 14, 2021 · 2 comments
Closed

Failure to present file browser when ParseUI is presented #19

johndelong opened this issue Jun 14, 2021 · 2 comments

Comments

@johndelong
Copy link

We have a UITabBarController in our app. Each tab is a UINavigationController. From one of these navigation controllers, we present the MainViewController as opposed to pushing it in order to avoid two rows of bottom tabs (one for our tab bar, and another one for the PulseUI tab bar).

Everything works fine about this approach until we try to tap the "Browse Files" button in the "Settings" tab. When we tap this button, we get the following error.

[Presentation] Attempt to present <PulseUI.DocumentBrowserViewController: 0x7fd62f58a6f0> on <UIViewController: 0x7fd62f50e650> (from <UIViewController: 0x7fd62f50e650>) which is already presenting <PulseUI.MainViewController: 0x7fd62812fa00>.

Seems to me that the MainViewController is trying to present from the presentingViewController instead of just presenting from itself. Because the presented view can present another view on top of itself, I think a possible solution for this would be to just have the instance of MainViewController present the file browser.

image

@hugovanderlei
Copy link

Same problem here

@kean
Copy link
Owner

kean commented Jul 2, 2021

Should be fixed in https://github.com/kean/Pulse/releases/tag/0.15.2

@kean kean closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants