Skip to content

Commit

Permalink
Disable silly credo rules and fix dialyzer error
Browse files Browse the repository at this point in the history
ParenthesesOnZeroArtiyDefs conflicts with the formatter and PipeChainStart
is dumb (IMO)
  • Loading branch information
mhanberg committed Sep 15, 2019
1 parent 93e58b3 commit 69eb3a1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .credo.exs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{Credo.Check.Readability.ModuleAttributeNames},
{Credo.Check.Readability.ModuleDoc},
{Credo.Check.Readability.ModuleNames},
{Credo.Check.Readability.ParenthesesOnZeroArityDefs},
{Credo.Check.Readability.ParenthesesOnZeroArityDefs, false},
{Credo.Check.Readability.ParenthesesInCondition},
{Credo.Check.Readability.PredicateFunctionNames},
{Credo.Check.Readability.PreferImplicitTry},
Expand All @@ -102,7 +102,7 @@
{Credo.Check.Refactor.NegatedConditionsInUnless},
{Credo.Check.Refactor.NegatedConditionsWithElse},
{Credo.Check.Refactor.Nesting},
{Credo.Check.Refactor.PipeChainStart},
{Credo.Check.Refactor.PipeChainStart, false},
{Credo.Check.Refactor.UnlessWithElse},

{Credo.Check.Warning.BoolOperationOnSameValues},
Expand Down
4 changes: 2 additions & 2 deletions lib/wallaby/experimental/chrome.ex
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ defmodule Wallaby.Experimental.Chrome do
end

@doc false
@spec start_session([start_session_opts]) :: {:ok, Session.t()}
def start_session(opts) do
@spec start_session([start_session_opts]) :: Wallaby.Driver.on_start_session()
def start_session(opts \\ []) do
{:ok, base_url} = Chromedriver.base_url()
create_session_fn = Keyword.get(opts, :create_session_fn, &WebdriverClient.create_session/2)

Expand Down
2 changes: 1 addition & 1 deletion lib/wallaby/experimental/selenium.ex
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ defmodule Wallaby.Experimental.Selenium do
end

@doc false
@spec start_session([start_session_opts]) :: {:ok, Session.t()}
@spec start_session([start_session_opts]) :: Wallaby.Driver.on_start_session()
def start_session(opts \\ []) do
base_url = Keyword.get(opts, :remote_url, "http://localhost:4444/wd/hub/")
create_session_fn = Keyword.get(opts, :create_session_fn, &WebdriverClient.create_session/2)
Expand Down

0 comments on commit 69eb3a1

Please sign in to comment.