Fix bad button type error reporting. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keathley
force-pushed
the
bugs/bad-error-reporting-for-buttons
branch
from
cbcfeae
to
b3a3e6e
Compare
aaronrenner
approved these changes
May 13, 2017
PragTob
approved these changes
May 13, 2017
If there are duplicate buttons then Wallaby will incorrectly return an error saying that the button has a bad type. However, the real error is that the specified count is incorrect. This commit adds a test for this case and fixes the underlying bug.
PragTob
force-pushed
the
bugs/bad-error-reporting-for-buttons
branch
from
b3a3e6e
to
3320fd7
Compare
|
And another conflict... I don't believe it :| |
|
And finally this can go in :) |
graeme-defty
pushed a commit
to graeme-defty/wallaby
that referenced
this pull request
May 16, 2017
If there are duplicate buttons then Wallaby will incorrectly return an error saying that the button has a bad type. However, the real error is that the specified count is incorrect. This commit adds a test for this case and fixes the underlying bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are duplicate buttons then Wallaby will incorrectly return an error saying that the button has a bad type. But the real error is that the specified count is incorrect. This PR adds a test for this case and fixes the underlying bug.