Remove select and selected?/1 from Browser module.

[keathley]

This PR removes the select functions and selected?/1 from the Browser module. It would be very nice to have some sort of query composition for finding options inside of a given select. Because there are multiple "Option 2" options on the page you get a duplicate element error if you don't scope everything to the specific select.

[aaronrenner]

Why does this test call selected/2 and the one below calls Element.selected/2? Also would it be good to have a test to ensure this function returns false when the option is not selected?

[keathley]

The test below should be calling Element.selected?/1. I'll add a test to make sure that it returns false. Thats a good catch.

[keathley]

@aaronrenner Added the extra tests. Lemme know what you think.

[aaronrenner]

Thanks, the tests look good. Is the reason wallaby has Browser.selected and Element.selected is because Browser.selected has retry logic and Element.selected does not?

[keathley]

Partially. In general the Browser module provides functions that accept queries and provide retrying, etc. The Element module accepts elements and doesn't provide any retry logic. In fact the Element module really can't provide any retry logic. Typically if a query needs to be retried its because an element wasn't able to be found or it was found and then went stale half-way through the element validation (checking for text or visibilty). But the big separation is that Browser accepts queries instead of elements.

[aaronrenner]

That makes sense. Thanks for the explanation.