-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interacting with opened windows #421
Conversation
I think getting and setting window size or position using a handle is not supported in many WebDrivers. Since the user can always change focus to that window first before executing these commands, I'm going to simplify this PR and remove the versions that take a handle. I'll keep the change from "no handle" to "current" to designate the target window since it seems to be working fine and it's more spec compliant with the old protocol. |
@mhanberg @keathley I think this is good enough! I didn't add an integration test for A few existing commands got slightly changed to be more in-line with the Selenium WebDriver spec (w3c endpoints were being used), versions that take a window handle got dropped for simplicity (and because they returned values for current window for many browsers anyway), and return values got adjusted so that we always return |
… window-related commands
…rivers and Browser module
…ent for passing Session struct
Closes #360
TODO:
Revisit handling errors, reading the value from the response and return types (that's fine for now I think:ok
is just the happy path)For the unaware: I'm following the Selenium WebDriver Wire Protocol. The W3C WebDriver Protocol has too many changes to try to support both of them at the same time. We will need to have a separate WebdriverClient module for it for people that want to test in Safari 12 or newer, Edge 18 or newer, new Appium versions etc.