-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal spacing classes #106
Comments
@janmichek ak by si chcel, mozeme tam este nieco pridat, pripadne to urobit inak. Toto je len nejaky zaklad, aby si kazdy (ako napr. ja) nemusel vymyslat svoje classes, ked chce niecomu dat margin/padding. |
Jsem s tim v pohode, muze se to hodit. Vetsinou se snazim obejit bez techto helperu a vyresit to na urovni navrhu. Muze se z toho stat mor kdyz se to dostane pod ruku backendovym programatorum xD |
Kukni sa ked tak sem, tu je prve miesto, kde som to pouzil: https://github.com/keboola/kbc-ui/commit/3d04790dbcd9784ac120adb59f46dfd4585b5cbe Ak je to takto zle, kludne to poriesme, nech sa to fixne este v zarodku. ;) |
Me se to bohuzel moc nelibi. Zaplatujes chyby layoutu. Chapu proc to delas, ale paddingy by nemeli byt reseny temahle classama. Html se pak stane stylesheetem a je to uz videt -> 'no-padding', 'mx-2'. Melo by to byt vyreseny na urovni navrhu. Jen ve vyjimecnym pripade, pokud se svadi boj o specificitu selectoru, nebo jinych neresitelnych pripadech. Je to takovej quickfix, ale globalne pujde spis o zhorseni. |
Ok, preto ti pisem - skus to kludne navrhnut lepsie/opravit ma. ad je to jedno z mala miest kde sa to pouziva, ide o to, ze v orchestraciach v detaile jobu je to bez tych paddingov a natlacene navrch. pride mi lepsie tam dat ad pridava to horizontalny padding, prave na mieste, kde chybal. napr. v eventoch (orchestr. job detail) by som to na search bar mal dat tiez -> lebo tabulka je na full sirku no search uz potom vyzera zle. ad takto sa imho riesil padding v roku 2000 :) ... preco by som mal pridat markup kvoli vyrieseniu vertikalneho spacingu? to uz dam radsej inline style. |
@janmichek rozmyslam, ze by som toto vyhodil, ked tie spacing classy nechceme pouzivat ... alebo to nechat prave na hotifxy ako bol ten detail eventu? |
Predelam lepe to co jsem dneska hotfixoval. |
In bootstrap v4, there are great spacing classes:
https://getbootstrap.com/docs/4.0/utilities/spacing/
I'll init something like that in indigo-ui.
The text was updated successfully, but these errors were encountered: