Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Chart 2.11.0 Throws Errors #481

Closed
pinkfloydx33 opened this issue Jun 22, 2023 · 6 comments · Fixed by #482
Closed

Upgrade to Chart 2.11.0 Throws Errors #481

pinkfloydx33 opened this issue Jun 22, 2023 · 6 comments · Fixed by #482
Labels
bug Something isn't working

Comments

@pinkfloydx33
Copy link

pinkfloydx33 commented Jun 22, 2023

Our Flux deployment of KEDA has attempted to automatically upgrade to the latest chart related a few minutes ago. It is failing and throwing the following message in the logs:

Helm upgrade failed: YAML parse error on keda/templates/manager/service.yaml: error converting YAML to JSON: yaml: line 7: did not find expected key

I don't have better logs at the moment as the above is what is reported by Flux on my HelmRelease resources. I can try and do a manual install into the environment and see if I get a better error message, but it would need to wait until at least tomorrow.

Expected Behavior

Chart succeeds

Actual Behavior

Chart fails

Steps to Reproduce the Problem

  1. Have 2.10.2 installed
  2. Upgrade to 2.11.0

Values:

nodeSelector:
  some/node.selector: 'true'
podIdentity:
  azureWorkload:
    clientId: ''
    enabled: true
prometheus:
  metricServer:
    enabled: true
  operator:
    enabled: true
    port: 8080
  webhooks:
    enabled: true

This is happening in multiple environments with similar values files.

Specifications

  • KEDA Version: chart 2.10.2 -> 2.11.0
  • Platform & Version: AKS
  • Kubernetes Version: 1.25.6
@pinkfloydx33 pinkfloydx33 added the bug Something isn't working label Jun 22, 2023
@tomkerkhove
Copy link
Member

🕵️‍♂️

@tomkerkhove
Copy link
Member

Regression got introduced in #432 and is caused here:
https://github.com/kedacore/charts/blob/main/keda/templates/manager/service.yaml#L10-L13

Mitigation: Add additionalAnnotations with dummy values

@tomkerkhove
Copy link
Member

Fixing it btw

@pinkfloydx33
Copy link
Author

Thanks @tomkerkhove!

Any ETA for release? I'd rather not add annotations as a work around in the interim. My dev environments are set to pick up minor/patch releases automatically so it'll fix itself, but really no rush... Just curious

@zroubalik
Copy link
Member

I dare to say we are gonna do the release in a few hours.

@tomkerkhove
Copy link
Member

Creating one now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants