Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Trust Server SSL Certificate (unsafe ssl) for RabbitMQ Scaler #4448

Closed
jade-lucas opened this issue Apr 13, 2023 · 3 comments · Fixed by #4571
Closed

Add Support for Trust Server SSL Certificate (unsafe ssl) for RabbitMQ Scaler #4448

jade-lucas opened this issue Apr 13, 2023 · 3 comments · Fixed by #4571
Assignees
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion

Comments

@jade-lucas
Copy link

jade-lucas commented Apr 13, 2023

Proposal

Currently TLS is hardcoded to not allow unsafe ssl. This is not ideal for environments that use VIPs, load balancers, wild carded ssl certs, etc. Purposing to add support for the unsafeSsl option for the RabbitMQ scaler. This would help keep parity with other scalers, stay inline with the documentation (https://keda.sh/docs/2.10/operate/security/), and also keep behavior similar to other RabbitMQ clients SDKs. More specifically support for trusting the server ssl certificate. Other RabbitMQ Client SDKs allow you to require ssl, but also allow you to trust the server ssl certificate or only do CA verify.

image
image

Use-Case

Allows us to use keda in our environment. We have a load balancer sitting in front of our RMQ cluster that does ssl pass through. Meaning there is no ssl termination at the load balancer. This means that the host attribute in ssl certs coming back from the cluster don't align the host being called by the client, which fails full ssl verification.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@jade-lucas jade-lucas added feature-request All issues for new features that have not been committed to needs-discussion labels Apr 13, 2023
@JorTurFer JorTurFer added the help wanted Looking for support from community label Apr 17, 2023
@zroubalik
Copy link
Member

@JorTurFer this is the stuff we talked about, right?

@JorTurFer
Copy link
Member

This is related, yes (it's not the same because I wanted to integrate the CAs, but we can do both at once)

@dttung2905
Copy link
Contributor

@zroubalik @JorTurFer this seems similar to the issue that I closed yesterday where I add an extra arg unsafeSsl in trigger metadata . Do you want me to work on this as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community needs-discussion
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

4 participants