Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Azure Data Explorer 'metadata.clientSecret' #4514

Closed
JorTurFer opened this issue May 2, 2023 · 5 comments
Closed

Remove Azure Data Explorer 'metadata.clientSecret' #4514

JorTurFer opened this issue May 2, 2023 · 5 comments
Assignees
@JorTurFer
Labels
breaking-change deprecation:active removal:keda-v2.13

Comments

@JorTurFer
Copy link
Member

JorTurFer commented May 2, 2023 •
edited

Report

We are allowing to provide secrets as plain text in metadata section, we should remove as metadata isn't safe for managing secrets

The message has been added, we should delete it in 2.13
.
@JorTurFer JorTurFer added bug Something isn't working deprecation:active and removed bug Something isn't working labels May 2, 2023
@JorTurFer JorTurFer self-assigned this May 2, 2023
@JorTurFer JorTurFer mentioned this issue May 2, 2023
Merged
2 tasks
@tomkerkhove
Copy link
Member

Agreed!

@tomkerkhove tomkerkhove mentioned this issue May 3, 2023
Merged
1 task
@JorTurFer
Copy link
Member Author

#4490

@tomkerkhove
Copy link
Member

@JorTurFer Can you please add/link the other aspects of our deprecation policy please?

https://github.com/kedacore/keda/discussions/categories/deprecations

https://github.com/kedacore/governance/blob/main/DEPRECATIONS.md#introducing-new-deprecations

@JorTurFer JorTurFer changed the title Deprecate Azure Data Explorer 'metadata.clientSecret' Remove Azure Data Explorer 'metadata.clientSecret' Jun 12, 2023
@JorTurFer JorTurFer mentioned this issue Oct 2, 2023
Merged
4 tasks
@dttung2905 dttung2905 mentioned this issue Oct 4, 2023
Closed
@tomkerkhove
Copy link
Member

@JorTurFer Can you please add/link the other aspects of our deprecation policy please?

https://github.com/kedacore/keda/discussions/categories/deprecations

https://github.com/kedacore/governance/blob/main/DEPRECATIONS.md#introducing-new-deprecations

@JorTurFer This can be closed I think, but did we do this?

@JorTurFer
Copy link
Member Author

yeah, this has been already removed as part of #5038, so I close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
breaking-change deprecation:active removal:keda-v2.13
Projects
Roadmap - KEDA Core
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomkerkhove @JorTurFer