Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ScaledJob logic under scale_handler.go #4781

Closed
yoongon opened this issue Jul 8, 2023 · 3 comments · Fixed by #4707
Closed

Move ScaledJob logic under scale_handler.go #4781

yoongon opened this issue Jul 8, 2023 · 3 comments · Fixed by #4707
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@yoongon
Copy link
Contributor

yoongon commented Jul 8, 2023 •
edited

Proposal

Compared to ScaledObject, ScaledJob related logic remains at scalers_cache.go.
ScaledObject related logic already moved to scale_handler.go, so ScaledJob should be moved as well.

Therefore, ScaledJob related code should be refactored like ScaledObject to increase readbility.

FYI

keda/pkg/scaling/cache/scalers_cache.go

Line 144 in bce3375

// TODO needs refactor - move ScaledJob related methods to scale_handler, the similar way ScaledObject methods are

Use-Case

No response

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response
@yoongon yoongon added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 8, 2023
@yoongon
Copy link
Contributor Author

yoongon commented Jul 8, 2023

I filed this issue to track this change. Please assign it to me, or resolve this one when the change is reviewed and merged.
#4707

@tomkerkhove tomkerkhove mentioned this issue Jul 10, 2023
Merged
3 tasks
@tomkerkhove
Copy link
Member

@kedacore/keda-maintainers Any thoughts?

@zroubalik
Copy link
Member

@kedacore/keda-maintainers Any thoughts?

@tomkerkhove wdym? This issue is already in progress and the PR under review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Status: Ready To Ship
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: refactor ScaledJob to be used with scale_handler yoongon/keda
3 participants
@zroubalik @tomkerkhove @yoongon