Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scalers package #5379

Closed
zroubalik opened this issue Jan 16, 2024 · 0 comments · Fixed by #5381
Closed

Refactor scalers package #5379

zroubalik opened this issue Jan 16, 2024 · 0 comments · Fixed by #5381
Assignees
@zroubalik

Comments

@zroubalik
Copy link
Member

Proposal

We should slightly refactor scalers package, it is hard to create subpackages there (for example pkg/scalers/aws, pkg/scalers/...) that needs to use ScalerConfig. Because this introduces circular dependency.

We should move ScalerConfig out and refactore the package a little bit.

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response
@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Jan 16, 2024
@zroubalik zroubalik self-assigned this Jan 16, 2024
@zroubalik zroubalik removed needs-discussion feature-request All issues for new features that have not been committed to labels Jan 16, 2024
This was referenced Jan 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zroubalik zroubalik

Labels
None yet
Projects
Roadmap - KEDA Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor scalers package and move ScalersConfig zroubalik/keda
1 participant
@zroubalik