Respect optional param for ConfigMaps and Secrets

[tomislater]

I am working on tests, but it might take some time :) I am new here.

#555

[zroubalik]

LGTM, thanks @tomislater

[tomislater]

Uhh, I do not know how to start writing tests here for something other than scalers.
Handlers do not have any tests currently.

I wanted to use fake client like here or here. But, I have got this error:

pkg/handler/scale_handler_test.go:22:2: cannot use "k8s.io/client-go/kubernetes/fake".NewSimpleClientset() (type *"k8s.io/client-go/kubernetes/fake".Clientset) as type client.Client in field value:
        *"k8s.io/client-go/kubernetes/fake".Clientset does not implement client.Client (missing Create method)

when I want to create test ScaleHandler:

var testScaleHandler = ScaleHandler{
	client:           testclient.NewSimpleClientset(),
	reconcilerScheme: scheme.Scheme,
}

Do you have any suggestions? Or maybe someone is working on writing tests for handlers?

I have tested it on my cluster and it works, but still... :P

[ahmelsayed]

We're using operator-sdk for interacting with kuberentes, so you'll have to create the fake client like this https://github.com/operator-framework/operator-sdk/blob/master/doc/user/unit-testing.md

That part is currently only partially covered by the integration tests under tests/

[tomislater]

Thanks, I am going to add tests.

[msftclas]

All CLA requirements met.

[ahmelsayed]

Thank you very much @tomislater