Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameters 'rate' and 'count' for GCP Stackdriver Scaler alignment #5633

Closed
binboum opened this issue Mar 28, 2024 · 1 comment
Closed

Missing parameters 'rate' and 'count' for GCP Stackdriver Scaler alignment #5633

binboum opened this issue Mar 28, 2024 · 1 comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@binboum
Copy link
Contributor

binboum commented Mar 28, 2024

Proposal

  • Add missing case for "rate" parameter in the alignerFromString function
  • Add missing case for "count" parameter in the reducerFromString function

from : ./pkg/scalers/gcp/gcp_stackdriver_client.go

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response
@binboum binboum added feature-request All issues for new features that have not been committed to needs-discussion labels Mar 28, 2024
@binboum binboum mentioned this issue Mar 28, 2024
Merged
3 tasks
@JorTurFer
Copy link
Member

This is already done! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Status: Ready To Ship
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binboum @JorTurFer