Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move samples under KEDA 2.0 #31

Closed
Shubham82 opened this issue Jun 1, 2021 · 4 comments · Fixed by #32
Closed

Move samples under KEDA 2.0 #31

Shubham82 opened this issue Jun 1, 2021 · 4 comments · Fixed by #32
Labels
bug Something isn't working

Comments

@Shubham82
Copy link
Contributor

Move the GCP PubSub sample i.e. Google Cloud PubSub and Kafka sample i.e Azure Functions Kafka on Openshift 4 under KEDA 2.0 as they have supported KEDA 2.0 version and also modify their links(acc. to keda 1.0) under KEDA 1.0
@Shubham82 Shubham82 added the bug Something isn't working label Jun 1, 2021
@Shubham82
Copy link
Contributor Author

@tomkerkhove @zroubalik
PTAL!

If it seems good then I will raise a PR for it!
Thanks

@tomkerkhove
Copy link
Member

If they are upgraded then feel free to send a PR

@Shubham82
Copy link
Contributor Author

yes, in their respective repo they have support for keda2.0.
I will soon create a PR for it.

@Shubham82 Shubham82 mentioned this issue Jun 2, 2021
Merged
1 task
@Shubham82
Copy link
Contributor Author

Fixed it here #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move samples to KEDA 2.0 Shubham82/samples
2 participants
@tomkerkhove @Shubham82