Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datasets argument keywords only #247

Closed
noklam opened this issue Jun 20, 2023 · 1 comment · Fixed by #358
Closed

Make datasets argument keywords only #247

noklam opened this issue Jun 20, 2023 · 1 comment · Fixed by #358
Labels
Community Issue/PR opened by the open-source community good first issue Good for newcomers help wanted Contribution task, outside help would be appreciated!

Comments

@noklam
Copy link
Contributor

noklam commented Jun 20, 2023

Description

Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
kedro-org/kedro#1936 (comment)

This will give us more freedom to change the order of arguments without breaking changes. This should be done before the 0.19.0 release.

Other links and ideas
Any redesign should be grounded on user research and user needs
@antonymilne suggested making dataset parameters keyword-only, which enables non-breaking refactoring post-0.19.0
If we think this is worth doing, we should open an issue and prioritize it sooner rather than later
GetInData "pipeline dataset" https://github.com/getindata/kedro-azureml/blob/develop/kedro_azureml/datasets/pipeline_dataset.py

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

@noklam noklam added help wanted Contribution task, outside help would be appreciated! Community Issue/PR opened by the open-source community good first issue Good for newcomers labels Jun 29, 2023
@noklam
Copy link
Contributor Author

noklam commented Jun 29, 2023

This should be relatively easy to fix, community contribution is very welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community good first issue Good for newcomers help wanted Contribution task, outside help would be appreciated!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant