Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linting and test files + setup from all starters #106

Closed
merelcht opened this issue Oct 18, 2022 · 1 comment
Closed

Remove linting and test files + setup from all starters #106

merelcht opened this issue Oct 18, 2022 · 1 comment

Comments

@merelcht
Copy link
Member

merelcht commented Oct 18, 2022

Description

Remove all linting dependencies and configuration:

  • setup.cfg completely
  • linting config from pyproject.toml
  • linting dependencies from requirements.txt: flake8, black, isort

Remove test setup:

  • src/test directory completely
  • pytest dependencies from requirements.txt

Update e2e test setup to still lint the starters by calling flake8, isort and black commands directly instead of kedro lint.

  • To make these checks all pass we would need to add test setup for flake8, because the default max line length is 79 and we've always worked with a max lint length of 88.

Context

Follow up on: kedro-org/kedro#1849

@astrojuanlu
Copy link
Member

Following the new utilities workflow kedro-org/kedro#2388 we'll keep these files.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants