You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the starters can break if a user has pandas 2.0 installed. Update all starters so they can run fine with pandas 2.0 as well as older versions. This means updating the pin for kedro-datasets to ~=1.0 instead of ~=1.0.0.
Context
For example in spaceflights:
This should not be a problem if the user follows the normal workflow, but if they install pandas 2 separately, things break:
I was about to do a quick demonstration of the spaceflights pipeline, and instead of following the normal process, I installed the dependencies "by hand".
Your Environment
Include as many relevant details about the environment in which you experienced the bug:
Kedro version used (pip show kedro or kedro -V): 0.18.8
Python version used (python -V): 3.10.10
Operating system and version: macOS Ventura
The text was updated successfully, but these errors were encountered:
merelcht
changed the title
spaceflights starter is broken with pandas 2
Update starters to support pandas 2.0
Jun 5, 2023
@astrojuanlu This issue only affects the spaceflights starter; everything else upgrades fine. It may have something to do with an underlying error from numpy, where the block size changes on cast, but I haven't yet figured this out. Will keep you posted if I make progress.
Edit: JK, think this is because of bad code in Spaceflights: x = x.str.replace("$", "", regex=True). If this is regex, it's replacing start of string marker? Which is why you get ValueError: could not convert string to float: '$1325.0' further down.
Description
Currently the starters can break if a user has pandas 2.0 installed. Update all starters so they can run fine with pandas 2.0 as well as older versions. This means updating the pin for
kedro-datasets
to~=1.0
instead of~=1.0.0
.Context
For example in spaceflights:
This should not be a problem if the user follows the normal workflow, but if they install pandas 2 separately, things break:
I was about to do a quick demonstration of the spaceflights pipeline, and instead of following the normal process, I installed the dependencies "by hand".
Your Environment
Include as many relevant details about the environment in which you experienced the bug:
pip show kedro
orkedro -V
): 0.18.8python -V
): 3.10.10The text was updated successfully, but these errors were encountered: