Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2691] Link kedro-starters CI exclusively to kedro main branch #66

Closed
merelcht opened this issue Feb 28, 2022 · 1 comment
Closed
Labels
Issue: Sprint Activity Issues to be completed on sprints

Comments

@merelcht
Copy link
Member

merelcht commented Feb 28, 2022

(transfer from Jira, created by @ignacioparicio)

Description

kedro-starters CI will fail whenever we update requirements.txt of kedro. This is because:

For now we are avoiding to do pip compile in order to deal with non-breaking changes in requirements.txt (see #36). A better solution:

  • Would have kedro-starters CI linked just to kedro's main branch, not the latest release
  • Would install just the requirements needed for each starter (status quo)

Possible implementation of this solution would be to patch requirements.txt in the kedro-starters CI to change any kedro[*]=={{ cookiecutter.kedro_version }} (which points to latest kedro release) to point to main instead. This would then enable a pure kedro install command to be run during CI (without the --no-build-reqs flag).

If a solution is found, we might consider reverting the changes made https://github.com/kedro-org/kedro-starters/pull/36/files, as they shouldn't be required anymore.

@merelcht merelcht added the Issue: Sprint Activity Issues to be completed on sprints label Feb 28, 2022
@merelcht merelcht changed the title [KED-2691] Link kedro-starters CI exclusively to kedro master branch [KED-2691] Link kedro-starters CI exclusively to kedro main branch Mar 28, 2022
@merelcht
Copy link
Member Author

Outdated ticket. We have already revamped the CI setup to use Github Actions and requirements have been moved to pyproject.toml. We can create a new task if something like this is still needed.

@merelcht merelcht closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Sprint Activity Issues to be completed on sprints
Projects
Status: Done
Development

No branches or pull requests

1 participant