Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart quotes in the legal disclaimers #17

Closed
wdearden opened this issue Jun 10, 2019 · 2 comments
Closed

Smart quotes in the legal disclaimers #17

wdearden opened this issue Jun 10, 2019 · 2 comments
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Help Wanted 🙏 Contribution task, outside help would be appreciated! Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@wdearden
Copy link

Description

There are smart quotes at several spots in the legal disclaimers. Here is one example but all examples can be found by searching the repo:
https://github.com/quantumblacklabs/kedro/blob/d3218bd89ce8d1148b1f79dfe589065f47037be6/kedro/template/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/%7B%7B%20cookiecutter.python_package%20%7D%7D/__init__.py#L17

Context

I discovered this while building the Sphinx docs for the Hello World example and getting a "Non-ASCII character" error.
@wdearden wdearden added the Issue: Bug Report 🐞 Bug that needs to be fixed label Jun 10, 2019
@tsanikgr tsanikgr added Difficulty: Starter Component: Documentation 📄 Issue/PR for markdown and API documentation Help Wanted 🙏 Contribution task, outside help would be appreciated! labels Jun 10, 2019
@yetudada
Copy link
Contributor

Thanks for raising this @wdearden! We're going to look into this one for you. We'll work on reproducing the error.

@yetudada
Copy link
Contributor

We've managed to resolve this issue in the latest release of Kedro. Check out Kedro 0.14.3, this PR and let us know your thoughts. Thank you once again for raising this bug @wdearden! 🚀

@921kiyo 921kiyo mentioned this issue Jul 3, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Help Wanted 🙏 Contribution task, outside help would be appreciated! Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsanikgr @wdearden @yetudada